gh-38807: fix race condition in Lib/trace.py#110143
Merged
Merged
Conversation
Instead of checking if a directory does not exist and thereafter creating it, directly call `os.makedirs` with the `exist_ok` kwarg.
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @buermarc for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @buermarc for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 17, 2024
Instead of checking if a directory does not exist and thereafter creating it, directly call os.makedirs() with the exist_ok=True. (cherry picked from commit 78fcde0) Co-authored-by: buermarc <44375277+buermarc@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 17, 2024
Instead of checking if a directory does not exist and thereafter creating it, directly call os.makedirs() with the exist_ok=True. (cherry picked from commit 78fcde0) Co-authored-by: buermarc <44375277+buermarc@users.noreply.github.com>
|
GH-114206 is a backport of this pull request to the 3.12 branch. |
|
GH-114207 is a backport of this pull request to the 3.11 branch. |
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
Instead of checking if a directory does not exist and thereafter creating it, directly call os.makedirs() with the exist_ok=True.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Instead of checking if a directory does not exist and thereafter creating it, directly call os.makedirs() with the exist_ok=True.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Instead of checking if a directory does not exist and thereafter creating it, directly call os.makedirs() with the exist_ok=True.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of checking if a directory does not exist and thereafter creating it, directly call
os.makedirswith theexist_okkwarg.